[ 
https://issues.apache.org/jira/browse/YARN-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446383#comment-15446383
 ] 

Hudson commented on YARN-5560:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10365 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10365/])
YARN-5560. Clean up bad exception catching practices in TestYarnClient. (jlowe: 
rev 4cbe61407dcb71f099bc7ec6ae87560d786ee714)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java


> Clean up bad exception catching practices in TestYarnClient
> -----------------------------------------------------------
>
>                 Key: YARN-5560
>                 URL: https://issues.apache.org/jira/browse/YARN-5560
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Sean Po
>            Assignee: Sean Po
>             Fix For: 2.8.0
>
>         Attachments: YARN-5560.v1.patch, YARN-5560.v2.patch, 
> YARN-5560.v3.patch
>
>
> In TestYarnClient, tests commonly wrap methods that throw exceptions in a try 
> catch statement similar to the following:
> {code}
> try {
>     client.submitApplication(context);
> } catch (Exception e) {
>     Assert.fail("Exception is not expected.");
> }
> {code}
> This hides useful error messages, and surfaces less helpful ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to