[ https://issues.apache.org/jira/browse/YARN-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449826#comment-15449826 ]
Karthik Kambatla commented on YARN-5566: ---------------------------------------- Patch makes sense to me. Minor comments: # RMNodeImpl: Nit - the comments in the added code don't add much information. We should remove them or added more details so they add some information. {noformat} // no running (and keeping alive) app on this node, get it // decommissioned. {noformat} # TestResourceTrackerService: The second heartbeat from node1 does not need to indicate running containers. # TestRMNodeTransitions#testGracefulDecommissionWithApp: When creating NodeStatus, we don't need to specify ContainerStatus when creating a new ArrayList > client-side NM graceful decom doesn't trigger when jobs finish > -------------------------------------------------------------- > > Key: YARN-5566 > URL: https://issues.apache.org/jira/browse/YARN-5566 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 2.8.0 > Reporter: Robert Kanter > Assignee: Robert Kanter > Attachments: YARN-5566.001.patch, YARN-5566.002.patch, > YARN-5566.003.patch > > > I was testing the client-side NM graceful decommission and noticed that it > was always waiting for the timeout, even if all jobs running on that node (or > even the cluster) had already finished. > For example: > # JobA is running with at least one container on NodeA > # User runs client-side decom on NodeA at 5:00am with a timeout of 3 hours > --> NodeA enters DECOMMISSIONING state > # JobA finishes at 6:00am and there are no other jobs running on NodeA > # User's client reaches the timeout at 8:00am, and forcibly decommissions > NodeA > NodeA should have decommissioned at 6:00am. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org