[ 
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450332#comment-15450332
 ] 

Daniel Templeton commented on YARN-5264:
----------------------------------------

Per our offline discussion, this patch is a step forwards in a refactoring of 
the fair scheduler data structures.  Future work will address the data 
duplication.

With that perspective in mind, I'm OK with the duplication of the data.  At 
least it's done cleanly.

My only gripe with the patch is that you introduced a spurious newline in 
{{TestFSLeafQueue}} so that there are two consecutive newlines.

> Use FSQueue to store queue-specific information
> -----------------------------------------------
>
>                 Key: YARN-5264
>                 URL: https://issues.apache.org/jira/browse/YARN-5264
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-5264.001.patch, YARN-5264.002.patch, 
> YARN-5264.003.patch, YARN-5264.004.patch
>
>
> Use FSQueue to store queue-specific information instead of querying 
> AllocationConfiguration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to