[ 
https://issues.apache.org/jira/browse/YARN-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468899#comment-15468899
 ] 

Sangeetha Abdu Jyothi commented on YARN-5331:
---------------------------------------------

Thanks for the comments, [~seanpo03]. I have updated the patch.

Regarding PeriodicRLESparseResourceAllocation::setTimePeriod:
As you pointed out, if the new period is smaller than the previous period, 
trimming is necessary. In addition, we also need to ensure that the existing 
reservations align with the new period (based on LCM condition). Since it is 
not possible to verify that while trimming, it might be better to create a new 
PeriodicRLESparseResourceAllocation in the InMemoryPlan when the global 
timePeriod has to change (InMemoryPlan has access to the existing periodic 
reservations). I have removed the function for now.

> Extend RLESparseResourceAllocation with period for supporting recurring 
> reservations in YARN ReservationSystem
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5331
>                 URL: https://issues.apache.org/jira/browse/YARN-5331
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sangeetha Abdu Jyothi
>         Attachments: YARN-5331.001.patch, YARN-5331.002.patch, 
> YARN-5331.003.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the 
> YARN ReservationSystem. This JIRA is a sub-task to add a 
> PeriodicRLESparseResourceAllocation. Please refer to the design doc in the 
> parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to