[ https://issues.apache.org/jira/browse/YARN-3692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483103#comment-15483103 ]
Sunil G commented on YARN-3692: ------------------------------- I think for trunk, patch looks fine. Few minor nits. 1. KillApplicationRequestPBImpl.java {{getDiagnostics}} might not need the below null check. {code} if (!p.hasDiagnostics()) { return null; } {code} 2. RMWebServices#updateAppState doesn't seem to have test coverage.Hence new change is not validated in this. I think a separate test jira could be added to handle the same. 3. One nit May be in ResourceMgrDelegate#killApplication, diagnosis ==> diagnostics As mentioned by you, more compatible approach is needed for branch-2. > Allow REST API to set a user generated message when killing an application > -------------------------------------------------------------------------- > > Key: YARN-3692 > URL: https://issues.apache.org/jira/browse/YARN-3692 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Rajat Jain > Assignee: Rohith Sharma K S > Attachments: 0001-YARN-3692.patch, 0002-YARN-3692.patch, > 0003-YARN-3692.patch, 0004-YARN-3692.patch > > > Currently YARN's REST API supports killing an application without setting a > diagnostic message. It would be good to provide that support. > *Use Case* > Usually this helps in workflow management in a multi-tenant environment when > the workflow scheduler (or the hadoop admin) wants to kill a job - and let > the user know the reason why the job was killed. Killing the job by setting a > diagnostic message is a very good solution for that. Ideally, we can set the > diagnostic message on all such interface: > yarn kill -applicationId ... -diagnosticMessage "some message added by > admin/workflow" > REST API { 'state': 'KILLED', 'diagnosticMessage': 'some message added by > admin/workflow'} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org