[ https://issues.apache.org/jira/browse/YARN-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515008#comment-15515008 ]
Yufei Gu commented on YARN-4907: -------------------------------- Some {{waitForState}} return a boolean since the caller need to assert on different value. Some {{waitForState}} doesn't since the caller expect them to assert if the state is reached before timeout. So it makes sense to have both. I changed all {{System.out.println}} to {{LOG.info}} and make sure every wait has a timeout. > Make all MockRM#waitForState consistent. > ----------------------------------------- > > Key: YARN-4907 > URL: https://issues.apache.org/jira/browse/YARN-4907 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-4907.001.patch > > > There are some inconsistencies among these {{waitForState}} in {{MockRM}}: > 1. Some {{waitForState}} return a boolean while others don't. > 2. Some {{waitForState}} don't have a timeout, they can wait for ever. > 3. Some {{waitForState}} use LOG.info and others use {{System.out.println}} > to print messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org