[
https://issues.apache.org/jira/browse/YARN-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546274#comment-15546274
]
Arun Suresh commented on YARN-5707:
-----------------------------------
Thanks for the patch [~vvasudev]. It looks mostly good..
Couple of comments:
* Think you can remove the default constructor {{ResourceProfilesManagerImpl()}}
* The profiles map can be final and initialized to ConcurrentHashMap.. that
way, you might not need to synchronize all the methods.
* I feel {{getResourceProfiles()}} should not return null... this would place
the burden of checking for null on the client. It would would be better if an
empty map is sent.
* Rather than explicitly asking the manager to reload, maybe it would be nice
to have a reloading thread that monitors a given file for changes. We do this
in the {{KMSACLs}} class.
> Add manager class for resource profiles
> ---------------------------------------
>
> Key: YARN-5707
> URL: https://issues.apache.org/jira/browse/YARN-5707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5707-YARN-3926.001.patch,
> YARN-5707-YARN-3926.002.patch
>
>
> Add a class that manages the resource profiles that are available for
> applications to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
