[ 
https://issues.apache.org/jira/browse/YARN-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563620#comment-15563620
 ] 

Li Lu commented on YARN-5699:
-----------------------------

Thanks for the work [~rohithsharma]! Generally fine but a few concerns:
1. I agree with Varun and Sangjin that we may need to think twice about 
diagnostic info. This field is way too cumbersome for users to directly query. 
I think it's fine to leave it in event info. 
2. When we get app state updated event, we may want to post the event info as 
is, but at the same time update entity level information?
3. A bigger concern is on the code itself. Right now we have a lot of info key 
name constants ending as "EVENT_INFO", but actually we no longer use them as 
event info. Instead, we may post them as entity info, or event info, or both. 
We need to update or simplify those constants to make them less confusing. 

> Retrospect yarn entity fields which are publishing in events info fields.
> -------------------------------------------------------------------------
>
>                 Key: YARN-5699
>                 URL: https://issues.apache.org/jira/browse/YARN-5699
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5699.YARN-5355.patch, 0001-YARN-5699.patch, 
> 0002-YARN-5699.YARN-5355.patch
>
>
> Currently, all the container information are published at 2 places. Some of 
> them are at entity info(top-level) and some are  at event info. 
> For containers, some of the event info should be published at container info 
> level. For example : container exist status, container state, createdTime, 
> finished time. These are general information to container required for 
> container-report. So it is better to publish at top level info field. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to