[
https://issues.apache.org/jira/browse/YARN-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565643#comment-15565643
]
Jason Lowe commented on YARN-5641:
----------------------------------
Thanks for the patch, Eric!
This has primarily become a change to the Shell in hadoop-common to fix a
problem with being able to interrupt it and kill the subprocess. Therefore I
think that change needs to be a JIRA in HADOOP rather than YARN along with a
better headline description. I'd move this one over to that project myself,
but there's the YARN change that is also needed. We could either move this or
file a JIRA in HADOOP that this depends upon. My preference is slightly
towards the latter but deferring the choice to you.
It would be good to have the error thread treated consistently, since now
stderr is handled with a raw thread and stdout is handled with an executor
service.
Speaking of executor service, why are we using a scheduled thread executor
service? We don't need the "scheduled" part of that service since we're just
using the submit method.
The OutOfMemoryError handling for the error thread isn't being applied to the
new stdout handling and should be for consistency.
The error handling of the future is silently eating any exception thrown whose
cause isn't an IOException or a RuntimeException. IMHO if the cause is an
IOException we should throw that, otherwise we should wrap it in a
RuntimeException.
> Localizer leaves behind tarballs after container is complete
> ------------------------------------------------------------
>
> Key: YARN-5641
> URL: https://issues.apache.org/jira/browse/YARN-5641
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Eric Badger
> Assignee: Eric Badger
> Attachments: YARN-5641.001.patch, YARN-5641.002.patch,
> YARN-5641.003.patch
>
>
> The localizer sometimes fails to clean up extracted tarballs leaving large
> footprints that persist on the nodes indefinitely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
