[ https://issues.apache.org/jira/browse/YARN-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572984#comment-15572984 ]
Eric Payne commented on YARN-2009: ---------------------------------- [~sunilg], I think you may have missed my comment from [above|https://issues.apache.org/jira/browse/YARN-2009?focusedCommentId=15553303&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15553303]: - {{FifoIntraQueuePreemptionPlugin#calculateIdealAssignedResourcePerApp}} -- The assignment to {{tmpApp.idealAssigned}} should be cloned: {code} tmpApp.idealAssigned = Resources.min(rc, clusterResource, queueTotalUnassigned, appIdealAssigned); ... Resources.subtractFrom(queueTotalUnassigned, tmpApp.idealAssigned); {code} -- In the above code, if {{queueTotalUnassigned}} is less than {{appIdealAssigned}}, then {{tmpApp.idealAssigned}} is assigned a reference to {{queueTotalUnassigned}}. Then, later, {{tmpApp.idealAssigned}} is actually subtracted from itself. So, I think the above code should be: {code} tmpApp.idealAssigned = Resources.clone(Resources.min(...)); {code} > Priority support for preemption in ProportionalCapacityPreemptionPolicy > ----------------------------------------------------------------------- > > Key: YARN-2009 > URL: https://issues.apache.org/jira/browse/YARN-2009 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler > Reporter: Devaraj K > Assignee: Sunil G > Attachments: YARN-2009.0001.patch, YARN-2009.0002.patch, > YARN-2009.0003.patch, YARN-2009.0004.patch, YARN-2009.0005.patch, > YARN-2009.0006.patch > > > While preempting containers based on the queue ideal assignment, we may need > to consider preempting the low priority application containers first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org