[ https://issues.apache.org/jira/browse/YARN-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606374#comment-15606374 ]
Karthik Kambatla commented on YARN-5388: ---------------------------------------- My bad. I missed the fix parts of the code in the rest of the unrelated improvements. +1. Checking both in.. (For the unrelated code readability etc. improvements, I always wonder if we should do it in a separate JIRA to avoid confusing folks looking at pulling this patch in later.) > MAPREDUCE-6719 requires changes to DockerContainerExecutor > ---------------------------------------------------------- > > Key: YARN-5388 > URL: https://issues.apache.org/jira/browse/YARN-5388 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Priority: Critical > Attachments: YARN-5388.001.patch, YARN-5388.002.patch, > YARN-5388.003.patch, YARN-5388.branch-2.001.patch, > YARN-5388.branch-2.002.patch, YARN-5388.branch-2.003.patch > > > Because the {{DockerContainerExecuter}} overrides the {{writeLaunchEnv()}} > method, it must also have the wildcard processing logic from > YARN-4958/YARN-5373 added to it. Without it, the use of -libjars will fail > unless wildcarding is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org