[ 
https://issues.apache.org/jira/browse/YARN-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610879#comment-15610879
 ] 

Varun Saxena commented on YARN-5773:
------------------------------------

[~bibinchundatt],
Below check for getNumActiveApplications is not required.
If cluster resources are 0, there is no point activating even one app.
{code}
703           if (!Resources.greaterThan(resourceCalculator, 
lastClusterResource,
704               lastClusterResource, Resources.none())
705               && !(getNumActiveApplications() < 1)) {
706             return;
707           }
{code}

I think a log can be added under the condition, maybe at DEBUG log level to 
avoid too many logs.

bq. Cluster resource UI is self explanatory, so required be add ??
I am +0 on this. [~sunilg], your thoughts on this ?

> RM recovery too slow due to LeafQueue#activateApplication()
> -----------------------------------------------------------
>
>                 Key: YARN-5773
>                 URL: https://issues.apache.org/jira/browse/YARN-5773
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Critical
>         Attachments: YARN-5773.0001.patch, YARN-5773.0002.patch, 
> YARN-5773.0004.patch, YARN-5773.003.patch
>
>
> # Submit application 10K application to default queue.
> # All applications are in accepted state
> # Now restart resourcemanager
> For each application recovery {{LeafQueue#activateApplications()}} is 
> invoked.Resulting in AM limit check to be done even before Node managers are 
> getting registered.
> Total iteration for N application is about {{N(N+1)/2}} for {{10K}} 
> application   {{50000000}} iterations causing time take for Rm to be active 
> more than 10 min.
> Since NM resources are not yet added to during recovery we should skip 
> {{activateApplicaiton()}} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to