[
https://issues.apache.org/jira/browse/YARN-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613418#comment-15613418
]
Karthik Kambatla commented on YARN-2083:
----------------------------------------
Firstly, thanks for working on this long-standing issue.
Correct me if I am wrong. Ideally, the check should be {{currentUsage +
newContainerCapacity <= maxShare}}. Changing it from {{currentUsage <=
maxShare}} to {{currentUsage < maxShare}} could address some cases, but not all
the cases. Can we look at fixing it for all cases, moving the place
assignContainerPreCheck is called if need be.
> In fair scheduler, Queue should not been assigned more containers when its
> usedResource had reach the maxResource limit
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2083
> URL: https://issues.apache.org/jira/browse/YARN-2083
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.3.0
> Reporter: Yi Tian
> Labels: BB2015-05-TBR, oct16-medium
> Attachments: YARN-2083-1.patch, YARN-2083-2.patch, YARN-2083-3.patch,
> YARN-2083-4.patch, YARN-2083.patch
>
>
> In fair scheduler, FSParentQueue and FSLeafQueue do an
> assignContainerPreCheck to guaranty this queue is not over its limit.
> But the fitsIn function in Resource.java did not return false when the
> usedResource equals the maxResource.
> I think we should create a new Function "fitsInWithoutEqual" instead of
> "fitsIn" in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
