[ https://issues.apache.org/jira/browse/YARN-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bibin A Chundatt updated YARN-5802: ----------------------------------- Attachment: YARN-5802.0002.patch Thank you [~sunilg] looking into the issue. {quote} Current approach in the patch is not handling runtime update priority for accepted/pending apps. {quote} Had added a query for the same. Thank you for confirming that we require update of {{pendingOrderingPolicy}} too. {quote} We might need to add contains method to OrderingPolicy interface for this. {quote} Thank you for input. Attaching patch after handling comment and adding testcases > Application priority updates add pending apps to running ordering policy > ------------------------------------------------------------------------ > > Key: YARN-5802 > URL: https://issues.apache.org/jira/browse/YARN-5802 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Critical > Attachments: YARN-5802.0001.patch, YARN-5802.0002.patch > > > {{LeafQueue#updateApplicationPriority}} > {code} > getOrderingPolicy().removeSchedulableEntity(attempt); > // Update new priority in SchedulerApplication > attempt.setPriority(newAppPriority); > getOrderingPolicy().addSchedulableEntity(attempt); > {code} > We should add again to ordering policy only when attempt available in first > case.Else during application attempt removal will try to iterate on killed > application still available in pending Ordering policy.Which can cause RM to > crash. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org