[
https://issues.apache.org/jira/browse/YARN-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622586#comment-15622586
]
Eric Payne commented on YARN-4218:
----------------------------------
Thanks, [~lichangleo], for updating the patches.
I'm looking into the patches, but I would like to provide a quick reminder
about patch naming conventions. From the [Hadoop: How To Contribute
Wiki|https://wiki.apache.org/hadoop/HowToContribute#Generating_a_patch]
{quote}
Patches for trunk should be named according to the Jira, with a version number:
<jiraName>.<versionNum>.patch,
{quote}
So, there is no need to put the word {{trunk}} in the name of trunk patches,
and the {{<versionNum>}} is preferred to be {{nnn}}. For example
{{YARN-4218.001.patch}}, {{YARN-4218.002.patch}}, etc.
For non-trunk branches:
{quote}
Patches for a non-trunk branch should be named
<jiraName>-<branchName>.<versionNum>.patch. ... The branch name suffix should
be the exact name of a git branch, such as "branch-2". Jenkins will check the
name of the patch and detect the appropriate branch for testing.
{quote}
The {{branch-2}} patches that you provided are correct except for the preferred
{{<versionNum>}}, but that's not a big deal.
> Metric for resource*time that was preempted
> -------------------------------------------
>
> Key: YARN-4218
> URL: https://issues.apache.org/jira/browse/YARN-4218
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: YARN-4218.2.patch, YARN-4218.2.patch, YARN-4218.2.patch,
> YARN-4218.2.patch, YARN-4218.3.patch, YARN-4218.4.patch, YARN-4218.5.patch,
> YARN-4218.branch-2.2.patch, YARN-4218.branch-2.patch, YARN-4218.patch,
> YARN-4218.trunk.2.patch, YARN-4218.trunk.3.patch, YARN-4218.trunk.patch,
> YARN-4218.wip.patch, screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> After YARN-415 we have the ability to track the resource*time footprint of a
> job and preemption metrics shows how many containers were preempted on a job.
> However we don't have a metric showing the resource*time footprint cost of
> preemption. In other words, we know how many containers were preempted but we
> don't have a good measure of how much work was lost as a result of preemption.
> We should add this metric so we can analyze how much work preemption is
> costing on a grid and better track which jobs were heavily impacted by it. A
> job that has 100 containers preempted that only lasted a minute each and were
> very small is going to be less impacted than a job that only lost a single
> container but that container was huge and had been running for 3 days.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
