On Fri, 11 Dec 2020 09:18:46 +0000 José Iván López González <[email protected]> wrote:
> On 12/9/20 3:56 PM, josef Reidinger wrote: > > Hi, > > I have PBI with idea that now when we have auto wrapping of lines for Label > > widget we could use it for Popup module. Reason is that it is often > > constructed and sometimes it include even output of some command. And if > > output has too long line, it is not visible. > > So idea looks good and when I use it for new Yast2::Popup class it works > > fine[1]. But when I try it for old Yast::Popup it is broken[2]. After > > debugging it appears it is caused by Stretch[3]. So my question now is how > > should I proceed? > > Possible options (do not hesitate to write other if I overlook something): > > > > 1. have auto wrapping just for Yast2::Popup and has Yast::Popup just as > > deprecated legacy class. And if bug report appear about long unreadable > > line, just use newer API. > > > > 2. Remove stretches from Yast::Popup. It can possible break layout > > somewhere and probably openQA would need to be adopted. > > > > 3. similar to 2. just instead of adapting layout, use from Yast::Popup > > calls to Yast2::Popup and keep it just as legacy backward compatible layer. > > > > As there is a plan to do some changes that affects openqa in January, I > > think that deadline to the end of December is good enough. My preferred > > solution is 1 as it basically start converging to one API. > > > > Josef > > I also prefer the option 1. Even, I would print a warning when the > deprecated Yast::Popup is used (similar to what ruby does when some API > is deprecated). > > But, on the other hand, personally I don't like how we usually deprecate > APIs in YaST. Basically, we add new classes but we never remove the > deprecated ones. As result, we accumulate a lot of zombies. Maybe, this > time we could go one step forward? > > Regards, > > Iván > Well, my rough ( it includes also new Popup API) and blink grep shows quite impressive number: jreidinger@localhost:~/prace/yast> ack -ch Popup\. 28966 So really non-trivial work. Josef _______________________________________________ YaST Development mailing list -- [email protected] To unsubscribe, email [email protected] List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette List Archives: https://lists.opensuse.org/archives/list/[email protected]
