On Tue, 30 Nov 2021 13:46:00 +0000
José Iván López González <[email protected]> wrote:

> On 11/24/21 09:11, josef Reidinger wrote:
> > 
> > And here is gist with all screenshots comparing both bottom and centered 
> > approach - 
> > https://gist.github.com/jreidinger/a33f72b7b859a2af6599cdbf9a1a485b  
> 
> IMHO, the centered version looks much better in ncurses than in QT 
> because it expands the whole dialog width. I suggest to do the same for 
> the QT version.

Thanks for feedback, I worry there is no easy way to switch layout (at least 
not see it in https://github.com/libyui/libyui/blob/master/libyui/src/YWizard.h 
), but I plan to try to close and reopen window in simple screen in QT. I hope 
blink will be really small.

> 
> And as David commented, maybe we could suppress the surplus buttons. In 
> fact, I would only keep Abort.

Sadly it was harder then I thought. Reason is this line in product workflow 
https://github.com/yast/yast-yast2/blob/9262f2a3829e4ffd34d48fec303530f19e0b9b0e/library/control/src/modules/ProductControl.rb#L1390
it cause that it is restored at the end of client. So even if I have it at the 
start, it reappear. If I add it to all steps, it still blink there as it was 
restored and hidden, causing some button movement on screen, so it does not 
look good. Only really working solution would be to merge all steps done after 
proposal screen to single client that do whole deployment. But I am not sure if 
it is worth and also non-trivial work :(

> 
> Regards,
> 
> Iván
> 

Josef

Reply via email to