On Wed, 24 Aug 2016 16:27:03 +0200 Josef Reidinger <[email protected]> wrote:
> Hi, > in last year we play a lot with different services and various > automatic checks for yast modules. I think it make sense that we after > SP2 and 42.2 branching start looking and discussing, what is useful, > what not and what is promissing. > Ideally if something is useful, then use it everywhere, if something > is not useful, then remove POC and if something is promising, then > try to invest time in its POC. > Reason why I mention it is, that I face it in last days few times, > e.g. that some modules do not use rubocop, so when I call rubocop > --auto-correct it basically destroy my changes, some modules do not > have spellchecker, so when we update in one module CONTRIBUTING.md, it > pass, but in other modules it cause crash as osc vc do not pass > spellchecker. > So I think we can start with discussion what is useful, what not now, > even before branching, so we can make conclusion and start working on > it. I will write down all projects I am aware of together with its POC > to see how it works. Feel free to react to any project how you see it > or add project if I forget any. > > projects: Hi, I do not see any response, so I will write my view and noone will object, I will start implementing it. > > travis build - https://travis-ci.org/yast/yast-yast2 - currently used > only for ruby modules and in other projects in other languages keep travis until jenkins one is ready > > jenkins build for pull requests - > http://ci.opensuse.org/job/yast-registration-github-push/586//console > - currently only in few yast modules Until we can deploy it for all modules I suggest to keep it in POC state. > > coveralls - https://coveralls.io/r/yast/yast-yast2?branch=master - > currently in few yast modules, do not support c++ my impression is that similar code coverage provide also code quality services, so we can drop this service and report coverage to quality service. > > codecov - https://codecov.io/gh/yast/yast-bootloader/pull/355?src=pr > and https://codecov.io/gh/jreidinger/libstorage-ng/pull/1?src=pr - > currently only POC for bootloader and libstorage-ng C++ support is promissing for our C++ projects, so I think we should start checking coverage there. > > codeclimate - https://codeclimate.com/github/yast/yast-yast2 - > currently for few yast modules and other ruby projects, do not support > c++ Currently codacy looks more promissing for me, as it integrate also test coverage ( so we have everything in place ). > > codacy - > https://www.codacy.com/app/YaST_Team/yast-bootloader/dashboard > - similar to codeclimate, only POC for bootloader, can integrate test > coverage, comment pull requests I suggest to use this service to integrate all of it and due to its commenting ability. > > inch - http://inch-ci.org/github/yast/yast-registration - checker for > documentation coverage, currently used only in yast2-registration as other services do not check this part I suggest to use it everywhere where service works. > > pullreview - > https://www.pullreview.com/github/yast/yast-registration/reviews/master > - sends mails to lslezak, currently only used in yast2-registration I think if we use codacy also for pull request commenting, then this one is duplicite. > > rubylint - https://github.com/yast/yast-yast2/pull/480 - checker for > errors in ruby, currently only POC for me it is still not usable, so I propose to keep it as POC > > rubocop - https://github.com/yast/yast-yast2/blob/master/.rubocop.yml > - currently used in many yast modules, but not all Suggest to use it everywhere where applicable. > > spellchecking - > https://github.com/yast/yast-yast2/blob/master/.travis.yml#L10 - > currently in few yast modules > We should use it everywhere. Josef -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
