> typo: s/about to being/about to begin/ (Several occurrences.) Thanks. Fixed.
> line 119 is missing a comma, as I found out the hard way. Ooh! So it is. Automatic string concatenation isn't one of my favorite Python features. Fixed. > In my branch I've moved the definition of 'log' into the helpers.py. > DRY. Sounds good. I'll leave that for your branch so as not to increase the already great chance of merge conflicts. > The sleep at 431 seems awful aggressive given the long time it takes > to deploy. My reasoning was more focused on getting out of the loop faster than worrying too much about how many times we go through the loop. I believe that doing 10 "juju status" commands a second is so cheap as to be negligible. Thanks for the good review. -- https://code.launchpad.net/~benji/charms/oneiric/buildbot-master/buildbot-master-lpbuildbot/+merge/91323 Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
