Review: Approve
Hi Gary,
Nice branch; thanks for this. I'll merge it presently with the master trunk.
363 + try:
364 + return subprocess.call(['buildslave', 'start', buildbot_dir])
365 + except OSError:
366 + return subprocess.call(['buildbot', 'start', buildbot_dir])
Instead of this you could do something like this:
def get_buildslave_command():
if subprocess.call(['which', 'buildslave']) == 0:
return 'buildslave'
else:
return 'buildbot'
and then call get_buildslave_command() where you need it.
--
https://code.launchpad.net/~gary/charms/oneiric/buildbot-master/run-as-buildbot/+merge/92399
Your team Launchpad Yellow Squad is subscribed to branch
lp:~yellow/charms/oneiric/buildbot-master/trunk.
--
Mailing list: https://launchpad.net/~yellow
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yellow
More help : https://help.launchpad.net/ListHelp
