Thanks Matthew, the inset border looks good, tests pass. +1 on landing this branch after fixing box shadows: see below.
https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newcode126 lib/views/stylesheet.less:126: -moz-box-shadow: inset 1px 0 0 lightgray; Here you can use the .create-box-shadow mixin. You can find it at the beginning of the file. It lets you create box shadows using a single rule and without repetitions. https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newcode801 lib/views/stylesheet.less:801: -webkit-box-shadow: inset 1px 0 0 lightgray; Same as above. https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newcode846 lib/views/stylesheet.less:846: width: @charm-panel-width - @charm-panel-padding-left - 1px; Really nice. https://codereview.appspot.com/6812107/ -- https://code.launchpad.net/~makyo/juju-gui/charm-panel-border/+merge/133963 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/charm-panel-border into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
