Fly-by review. :-) Looks good to me, but I didn't do a full review because you had the ones you needed. Thanks!
Gary https://codereview.appspot.com/6856112/diff/5001/hooks/start File hooks/start (right): https://codereview.appspot.com/6856112/diff/5001/hooks/start#newcode23 hooks/start:23: import json On 2012/11/30 10:24:22, frankban wrote: > I usually separate imports in 3 groups: stdlib (see os and sys above), other > installed libraries (e.g. charmhelpers) and application ones (utils). Inside > each group, libraries are imported in alphabetical order. json should be placed > in the first group. Anyway, this is just a suggestion, do with it what you want, > I am not sure we have a code style for that. It does appear to be the current style of the file, which we like to honor. Also, what Francesco suggests is the recommended PEP 8 style (http://www.python.org/dev/peps/pep-0008/#imports) with the addition of alphabetical sorting. https://codereview.appspot.com/6856112/ -- https://code.launchpad.net/~makyo/charms/precise/juju-gui/juju-gui/+merge/136985 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/charms/precise/juju-gui/juju-gui into lp:~juju-gui/charms/precise/juju-gui/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
