Request rereview (needs fixes). I have one minor comment about the code, but was unable to complete a functional test or a more in-depth look at the branch. Running make build, server, or debug gave me four of these errors: http://pastebin.ubuntu.com/1408941/ - this happened both after first checking out the branch and also after make clean. When running the branch, I would get a 404 on all-static.css, all-yui.js, and app.js; cache flushed and force-reloaded, same errors.
https://codereview.appspot.com/6865054/diff/1/lib/merge-files.js File lib/merge-files.js (right): https://codereview.appspot.com/6865054/diff/1/lib/merge-files.js#newcode27 lib/merge-files.js:27: var regex = /\(["']?((\.\/|\.\.\/)[^)]*)["']\)/g; I think that this regex could use some more explanation or a more descriptive variable name; it's a big one. https://codereview.appspot.com/6865054/ -- https://code.launchpad.net/~benji/juju-gui/bug-1078978/+merge/137650 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~benji/juju-gui/bug-1078978 into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
