Hope you don't mind a third review. Looks good with some small suggestions. Re-review not required.
https://codereview.appspot.com/6898043/diff/3001/hooks/install File hooks/install (right): https://codereview.appspot.com/6898043/diff/3001/hooks/install#newcode50 hooks/install:50: The run command returns stdout. My branch adds a 'cmd_log' command which will log the output if run is wrapped by it, i.e. cmd_log(run(...)) If my branch lands before yours please consider adding it to any of the run-based commands, which includes 'command' and derivatives. https://codereview.appspot.com/6898043/diff/3001/revision File revision (right): https://codereview.appspot.com/6898043/diff/3001/revision#newcode1 revision:1: 16 I think it is pretty trivial, but shouldn't the revision number on trunk only increment by 1 instead of leaving it at the number you used during development? Doing so will require an examination of trunk just before you land. https://codereview.appspot.com/6898043/ -- https://code.launchpad.net/~makyo/charms/precise/juju-gui/serve-static/+merge/138502 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/charms/precise/juju-gui/serve-static into lp:~juju-gui/charms/precise/juju-gui/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
