Thanks for helping me understand this. As I expected, I'm +1 on the code. I would like a bug/card to fix the prod tests on start. I'd like to see if we can fix the viewport resize issue one way or another before we land.
Thank you Gary https://codereview.appspot.com/6971045/diff/17/app/assets/javascripts/d3-components.js File app/assets/javascripts/d3-components.js (right): https://codereview.appspot.com/6971045/diff/17/app/assets/javascripts/d3-components.js#newcode328 app/assets/javascripts/d3-components.js:328: bindAllD3Events: function() { Comment describing behavior and saying that the expected client of this is the component might be nice. https://codereview.appspot.com/6971045/diff/17/app/views/topology/panzoom.js File app/views/topology/panzoom.js (right): https://codereview.appspot.com/6971045/diff/17/app/views/topology/panzoom.js#newcode107 app/views/topology/panzoom.js:107: * Wraper around the actual rescale method for zoom buttons. Wrapper https://codereview.appspot.com/6971045/ -- https://code.launchpad.net/~bcsaller/juju-gui/topology-panzoom/+merge/140671 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bcsaller/juju-gui/topology-panzoom into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
