Reviewers: mp+141105_code.launchpad.net, Message: Please take a look.
Description: Allow using an own SSL cert and private key. Added two new config options, one for the certificate, one for the private key. If they are both provided, they are used by nginx, otherwise, a new certificate is automatically generated. Fixed a pre-existent bug: even if you can specify the directory where to store the certificates, this path was not used by nginx, because an hardcoded one was present in the configuration file. Improved how ssl options are handled in config-changes. If the SSL path is changed using 'juju set', now that change is reflected in the nginx config file, and the service correctly restarted. Added tests for the process of saving or generating SSL certificates. Some code clean up. Please note that all the SSL stuff is still disabled/commented. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1092515-certificates/+merge/141105 (do not edit description out of merge proposal) Please review this at https://codereview.appspot.com/6976046/ Affected files: [revision details] config.yaml config/nginx.conf.template hooks/config-changed hooks/install hooks/start hooks/utils.py tests/test_utils.py -- https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1092515-certificates/+merge/141105 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/charms/precise/juju-gui/bug-1092515-certificates into lp:~juju-gui/charms/precise/juju-gui/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
