needs work
https://codereview.appspot.com/7007047/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7007047/diff/1/app/app.js#newcode544 app/app.js:544: if (!view.waiting && !view.userIsAuthenticated) { this content belongs in the app, not the view. the app needs to re-login on a socket reconnect. https://codereview.appspot.com/7007047/diff/1/app/app.js#newcode547 app/app.js:547: next(); this is an either or proposition, not an and. we either display the login or the app, not overlay the login over the app, which will be broken without a working ws. https://codereview.appspot.com/7007047/diff/1/app/store/env.js File app/store/env.js (right): https://codereview.appspot.com/7007047/diff/1/app/store/env.js#newcode77 app/store/env.js:77: this.set('serverReady', true); instead of introducing another value just move connected down here. https://codereview.appspot.com/7007047/ -- https://code.launchpad.net/~benji/juju-gui/login/+merge/141133 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~benji/juju-gui/login into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
