On Wed, Jun 25, 2008 at 1:26 AM, Jean-Philippe Bernardy
<[EMAIL PROTECTED]> wrote:
>
> This looks good. However, I wonder if it's the end of the story: I see
> that we pass the (undocumented!) option
> "-no-recomp" to GHC ... It feels like this should be disabled if
> 'force' is True. Similarly, shouldn't we remove all *.o *.hi files?
> This seems a bit drastic though.

Aye. The compilation process that HConf performs needs some polish.
A summary of the documentation I can find for "no-recomp" is:
 1. The option is deprecated and the option "-fforce-recomp" is the
preferred equivalent. At first I thought the equivalent option was
"-fno-force-recomp" but I think "no-recomp" is supposed to be read "no
recompilation checking". From 6.6-notes.xml:
          -no-recomp option is now called -fforce-recomp.
 2. That option means that ghc will not check if compiling the source
file will actually generate a new .hi and .o file. A new .o and .hi
file will always be regenerated. Which makes sense for
--recompile-force.
 3. -fno-force-recomp is the default.

The recompilation process looks to duplicate the source file
modification time check performed above the execution of ghc. So maybe
that code can be eliminated?

My biggest issue with the current recompile method is that a
dependency check on changes to the libraries linked with the yi.o file
is not performed. Course, this might only be an issue for somebody
doing development on Yi and may be costly to get right.

-Corey

> Cheers,
> JP.
>
> On Wed, Jun 25, 2008 at 6:07 AM, Corey O'Connor
> <[EMAIL PROTECTED]> wrote:
>>
>> Tue Jun 24 23:56:05 EDT 2008  [EMAIL PROTECTED]
>>  * Cleanup of HConf command line options handling.
>>
>>    M ./HConf.hs -8 +34
>>    M ./Yi.hs -4 +1
>>    M ./Yi/Main.hs -5 +10
>>
>> View patch online:
>>
>>  
>> http://code.haskell.org/yi/_darcs/patches/20080625035605-f0a0d-e32cdb7639ae85570498f1ece1d872df512703e9.gz
>>
>> >
>>
>
> >
>



-- 
-Corey O'Connor

--~--~---------~--~----~------------~-------~--~----~
Yi development mailing list
[email protected]
http://groups.google.com/group/yi-devel
-~----------~----~----~----~------~----~------~--~---

Reply via email to