On Mon, Aug 10, 2009 at 5:23 PM, Colin McQuillan<[email protected]> wrote: > > 2009/8/7 Jean-Philippe Bernardy <[email protected]>: >> >> Fri Aug 7 17:09:32 EDT 2009 [email protected] >> * fix a memory leak; also improve the style somewhat >> Ignore-this: 12b9966fd67f3ebf9a2e5bc48a7b98ef >> >> M ./src/Yi/UI/Vty.hs -4 +9 > > > The "fix" was meant to stop a leak where every window hangs onto the > last version of that window.
First I removed a retention of the editor object. Later I removed the retention you describe. I guess that the 1st fix isn't necessary given the 2nd. > I see you changed this in a later > revision but what was the original problem? Somehow this leak wasn't eating up so much memory, but it made GC very slow. > Are you using heap > profiling? Yes. Cheers, JP. --~--~---------~--~----~------------~-------~--~----~ Yi development mailing list [email protected] http://groups.google.com/group/yi-devel -~----------~----~----~----~------~----~------~--~---
