On Sun, Sep 6, 2009 at 7:11 PM, Corey O'Connor<[email protected]> wrote: > > Sun Sep 6 13:05:40 EDT 2009 [email protected] > * (issue 298) hlGetTree cannot equal just focused. That is only the strokes > for the *last* window. > Ignore-this: 5541fcb35ddf57ed8b5944cece5750b4 > All caches related to a window's presentation should be on a per-window > basis. The "focused" part of > the syntax highlighter Cache is updated for each window in Yi.Core: > let e6 = fst $ runOnWins (snapInsB >> focusSyntaxB) e5 > However since the Cache only has a single focused member, and not one per > window, then the focused > for only the last window is retained.
Good analysis, however this patch has a significant performance impact when editing big files: the whole tree is linearized at each rendering. > The focused field should be removed from the Cache and moved to the Window > structure? That is the correct fix indeed. Cheers, JP. --~--~---------~--~----~------------~-------~--~----~ Yi development mailing list [email protected] http://groups.google.com/group/yi-devel -~----------~----~----~----~------~----~------~--~---
