On Thu, 2020-02-20 at 11:59 +0000, Paul Barker wrote: > I'm now looking into this... > > In sstate_checkhashes() we mark sstate as available if > fetcher.checkstatus() succeeds. Then at a later point > sstate_setscene() calls sstate_installpkg() calls pstaging_fetch() > calls fetcher.download() to actually get the sstate artifact. If the > artifact is removed from the mirror between these two accesses (due > to an sstate mirror clean up running in parallel to a build), or if > there is an intermittent download failure we could see checkstatus() > succeed then download() fail. > > I don't think we should ignore all setscene errors but in the > specific case where it's the download step that fails I think that > should be a warning. Or it could be an error by default with a > variable we can set to turn it into a warning. Does that sound > reasonable? If so I'll work up a patch.
Thinking about the code, I'm not sure how you're generically going to tell the difference between a setscene task that fails as the file disappeared compared to a setscene failure with another real error? :/ We could make all failed setscene tasks warnings but I think that buries actual real errors. This is probably why I've not changed the code before now. Special exit code values? :/ I'm open to proposals. I know we could put in some configuration option but in general I hate these as it just means more test matrix combinations and more ways for people to see different behaviours. They have a time/place but I'm not sure its here. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#48532): https://lists.yoctoproject.org/g/yocto/message/48532 Mute This Topic: https://lists.yoctoproject.org/mt/71426351/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
