Hi Quentin Happy to contribute but not all that familiar with emailing patches, sorry.
I lumped them together because if you modify the KERNEL_IMAGETYPE you trigger the bug. I agree moving it out of the include file would be the best way to go but if you dont have the directory in the KERNEL_DEVICETREE it will fail to compile, quickly searching other layers are handling it similar to how I have, probably just in a more robust way. Regards, Tony On Tue, 26 Sept 2023 at 18:08, Quentin Schulz <quentin.sch...@theobroma-systems.com> wrote: > > Hi Anthony, > > Thanks for the patch! > > On 9/26/23 06:36, Anthony Davies via lists.yoctoproject.org wrote: > > [You don't often get email from > > anthony.t.davies=gmail....@lists.yoctoproject.org. Learn why this is > > important at https://aka.ms/LearnAboutSenderIdentification ] > > > > From: Anthony Davies <anthony.t.dav...@gmail.com> > > > > Apologies, this is the correct patch > > > > Updated inc files to allow overriding KERNEL_IMAGETYPE in local.conf > > > > Fixed bug where dtb couldnt be found when generating KERNEL_IMAGETYPE > > other then fitImage image due to KERNEL_DEVICETREE containing the dtb > > directory which is not available in the DEPLOY_DIR_IMAGE directory > > Here we are missing your Signed-off-by. > > I would highly suggest to split this into two separate commits, one for > allowing to override the KERNEL_IMAGETYPE through local.conf and another > one for the device tree thing. > > On another topic, I really feel like this is more of an issue with the > class handling KERNEL_DEVICETREE when we're not using a fitImage don't > you think? Otherwise all layers will have to fix this one up and I don't > think that's the right way to go. > > Cheers, > Quentin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#61120): https://lists.yoctoproject.org/g/yocto/message/61120 Mute This Topic: https://lists.yoctoproject.org/mt/101589776/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
