Move chdir outside run_child to better handle when fails output an error
message plus remove the need to strdup inside run_child (already have
ptest_dir).
Signed-off-by: Anibal Limon <ani...@limonsoftware.com>
---
utils.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/utils.c b/utils.c
index 54394cc..472520f 100644
--- a/utils.c
+++ b/utils.c
@@ -327,7 +327,6 @@ static inline void
run_child(char *run_ptest, int fd_stdout, int fd_stderr)
{
char *const argv[2] = {run_ptest, NULL};
- chdir(dirname(strdup(run_ptest)));
dup2(fd_stdout, STDOUT_FILENO);
// XXX: Redirect stderr to stdout to avoid buffer ordering problems.
@@ -466,7 +465,11 @@ run_ptests(struct ptest_list *head, const struct
ptest_options opts,
fprintf(fp, "ERROR: Unable to attach to
controlling tty, %s\n", strerror(errno));
}
- run_child(p->run_ptest,
pipefd_stdout[PIPE_WRITE], pipefd_stderr[PIPE_WRITE]);
+ if (chdir(ptest_dir) == -1) {
+ fprintf(fp, "ERROR: Unable to
chdir(%s), %s\n", ptest_dir, strerror(errno));
+ } else {
+ run_child(p->run_ptest,
pipefd_stdout[PIPE_WRITE], pipefd_stderr[PIPE_WRITE]);
+ }
} else {
bool timedout = false;
--
2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62311): https://lists.yoctoproject.org/g/yocto/message/62311
Mute This Topic: https://lists.yoctoproject.org/mt/104001081/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
