On 12/09/2010 12:44 AM, Ke, Liping wrote:
Hi, Scott
The patch is in the attachment for your review. Below is some notes:
1) Basically I wouldn't like to change any logic of the original code.
2) -serial stdio and -nographic options are removed since they're be covered by
the extra parameters.
3) User input would be $poky-qemu qemux86 "<-nographic -m 300>"
4) -m input will be checked still. If it exceeds 128 for arm, it will be
changed back to
128M, same logic as before. And after parsing, -m option will be removed
and replaced by
Kernel options mem=128M for avoiding some instability issue.
Generally I modified very few, just add an extra parameters with least
intrusion of
Current logic.
Any comments are welcomed.
I will conduct more test with latest code in parallel.
Hi Criping,
Thanks for the patch. Overall I think this looks good.
However, one thing I feel the need to run by Richard, as he expressed
some preferences with how the poky-qemu script would work with regard to
options.
Richard: Criping's patch would remove the standalone options we had to
the poky-qemu script (e.g, nographic, serial) and instead requires the
user to specify them in one command option which can take any qemu
command switch.
So for example:
poky-qemu qemux86 nographic
would become:
poky-qemu qemux86 "<-nographic>"
The benefit of this is that this allows the user to specify any qemu
option they wish. Previously they were limited by the options we allowed
them to specify (which were quite limited).
I tend to feel that this approach is more flexible, and scales better
than having to support each and every qemu option with our own script
syntax. Is this acceptable, or should we continue to support our own
custom options in addition to Criping's new approach?
Scott
--
Scott Garman
Embedded Linux Distro Engineer - Yocto Project
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
