On Thursday 22 March 2012 08:56:08 Darren Hart wrote: > On 03/21/2012 05:26 PM, Paul Eggleton wrote: > > On Wednesday 21 March 2012 16:06:14 Darren Hart wrote: > >> Any objections to this going in? > > > > No objections, looks like a really useful tool; a couple of suggestions > > though (sorry for not looking at it earlier): > > > > * Is it worth checking if the target device is mounted and erroring out if > > so? > That's a good suggestion. Alright with you if that is a follow-on patch?
Sure, sounds fine to me. > > * Not sure but it may be worth waiting a few seconds after the sync before > > exiting; I've seen some hardware that returns control to userspace before > > the hardware has actually finished writing. > > That may be, but anything we assume will be wrong for some hardware. The > sticks I have flash an LED for a few seconds afterwards, indicating writing. Many do, yes. I guess it was just a simple idea to avoid potential issues particularly for those that don't have an LED. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
