Hi Jessica,

Zhang, Jessica wrote, On 31.01.2013 20:28:
Hi Timo,

I'm having a hard time figuring out the sequence of this patch series.
You have 01/18-09/18, then 10/17 is obsolete, then you have things
> like 12/18 and 12/17 and some have XX/18 and some have XX/17.

Sorry, for this mess! I accidentally mixed two versions of the patch
set in the folder I was running git send-email in.

> Can you do some cleanup and resend?

Sure. I will resend as v3.


Thanks,
Jessica

-----Original Message-----
From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On 
Behalf Of Timo Mueller
Sent: Wednesday, January 30, 2013 5:56 AM
To: yocto@yoctoproject.org
Cc: Timo Mueller
Subject: [yocto] [RFC v2 00/18][eclipse-poky] Storing yocto settings as target 
profiles

From: Timo Mueller <timo.muel...@bmw-carit.de>

Hi,

thanks for the feedback, I did some changes to the patch series accordingly.

First of all I've fixed the issues with the patches (duplicate method, missing 
fix for NewYoctoCProjectTemplate.java).

I also changed the functionality of the "new" button according to Jessica's feedback. The 
logic is changed to a "Save as ..."
approach. If the button is clicked the current values of the form are checked. 
If these are valid, the user can enter a name to store them as a new profile.

The last patch moves the "Save as ..." button to the bottom of the preference page alongside with 
the "perform defaults" and the "apply"
button. I created this patch as a proof of concept because I thought it would 
be a good idea to move it.
I used the contributeButtons hook of the preference page to achieve this, but this only allows 
adding the "Save as ..." button left to the "perform defaults" button. So the 
order of the buttons is a bit confusing.
I further checked several other preference pages of eclipse and it seems like 
none of them is using this hook to add new buttons. Instead all have a new 
button next to the comboboxes (e.g. Formatter for CDT and JDT).
So I would plead against moving it to the bottom to have a more consistent and 
less confusing ui.

 From the original cover letter:
<snip>
currently the yocto settings can be changed globally through eclipse's 
preferences or locally in the project properties. But the standard 
configuration stored in the global preferences sometimes changes, e.g. if a new 
version of the toolchain or the sysroot is released.
If you change the global settings to the updated toolchain or sysroot your old 
working configuration is gone. If you want to reuse this configuration at a 
later point in time you have to (remember and) re-enter everthing.
This patch set introduces the possiblity to store a configuration under a 
unique name, a so called target profile, and be able to select the default 
target profile that is used for new projects.
Building upon this change the target profiles could later also be used in the 
project settings and be able to quickly build and debug your software for 
different hard- and software combinations.
</snip>

Best regards,
Timo

Best regards,
Timo
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to