Hi Atanas,
Please see my comments below... Thanks, Jessica From: Atanas Gegov [mailto:atanas.gegov....@gmail.com] Sent: Wednesday, April 24, 2013 8:48 AM To: Zhang, Jessica Cc: yocto@yoctoproject.org Subject: Re: [yocto] [eclipse-poky][RFC 0/6] Introducing a YoctoSDKCMakeProjectNature Hi Jessica, thank you for the comments! 1. Yes, the idea is that at the end there are the current category ("Yocto Project ADT Autotools Project" with some Autotools-based project templates) and a new category "Yocto Project ADT CMake Project" with e.g. its own "Hello World C++ CMake Project". The latter category and the templates will be implemented in the upcoming patch series. Great that's what I'd expected . 2. Could you please give me a small example how it should look like?Should the method addNatures receive a list of natures to add? What is the case if more natures are added to a project (e.g. SDKNature + AutotoolsNature + EmptyNature)? Or do you think of enum based on the buildsystem natures only (Autotools vs. CMake) and not based on all 4 natures? I took another look of the class, we should be able to even further simplify the API of addNatures. We can make all the natures as instance variables of the class. In process method we assign them values and totally eliminate passing natures in addNatures API. So the code should be(please ignore the incorrect capitalization due to auto correction): Public class NewYoctoProjectTemplateProcess extends ProcessRunner { ... Private Boolean isEmptyProject; Private Boolean isAutotoolsProject; Private Boolean isCMakeProject; ... Public void process(...) { ... isEmptyProject = ... isAutotoolsProject = ... isCMakeProject = ... ... addNatures(project, false, monitor); ... } ... Private void addNatures(IProject project, Boolean projectExists, IProgressMonitor monitor) { ... } 3. I just created an account in bugzilla.yoctoproject.org<http://bugzilla.yoctoproject.org/>, so you can assign me the CMake support entry. Super. You'll get your first assignment J Thanks, Atanas On Tue, Apr 23, 2013 at 8:50 PM, Zhang, Jessica <jessica.zh...@intel.com<mailto:jessica.zh...@intel.com>> wrote: Hi Atanas, Overall, the patches look good. Couple comments: 1. So from the end user perspective, after the 2nd patch set, user will see "Yocto Project ADT CMake Project" category when they want to create a new project? 2. Can we change the API for addNatures by using an enum type for projectNature instead of explicitly listing all of them out. This way is easier for code maintenance and API usability. 3. Don't know whether you've created a bugzilla account at bugzilla.yoctoproject.org<http://bugzilla.yoctoproject.org> or not, if not, please do, since I'd hope you're able to help fixing certain bugs in this area down the road. Also, from project planning process wise, we're right in the 1.5 planning, and I'd like to create an entry in the bugzilla for extending eclipse for CMake support and assign that to you, so it's easier to track what are the community contribution to the project. Thanks, Jessica -----Original Message----- From: yocto-boun...@yoctoproject.org<mailto:yocto-boun...@yoctoproject.org> [mailto:yocto-boun...@yoctoproject.org<mailto:yocto-boun...@yoctoproject.org>] On Behalf Of Atanas Gegov Sent: Monday, April 22, 2013 5:06 AM To: yocto@yoctoproject.org<mailto:yocto@yoctoproject.org> Subject: [yocto] [eclipse-poky][RFC 0/6] Introducing a YoctoSDKCMakeProjectNature From: Atanas Gegov <atanas.ge...@bmw-carit.de<mailto:atanas.ge...@bmw-carit.de>> Hi, This patch series introduces a YoctoSDKCMakeProjectNature as a new nature for CMake-based Yocto Projects in the IDE. It requires the basic YoctoSDKProjectNature and is an alternative to the YoctoSDKAutotoolsProjectNature. This does not affect the currently existing Autotools template projects. Upcoming patch series will add the last missing parts for having CMake projects in the IDE: a ManagedBuilder for CMake (CMake toolchain for building in Eclipse) and some template projects. However, I already wanted to post this series for a review and make sure that the concept is acceptable, so that we can build on top of it. Cheers, Atanas P.S: This patch series apply on the current master "plugins/sdk.ide: Extracted error message to YoctoSDKMessages" (7142c5fc82a41a9d5f86c48b289db0ef44f5a897). Atanas Gegov (6): plugins/sdk.ide: Prepared templates for CMake nature plugins/sdk.ide: Added a new YoctoSDKCMakeProjectNature plugins/sdk.ide: Enable the creation of CMake projects plugins/sdk.ide: Update CMake projects on Yocto settings change plugins/sdk.ide: Renamed template process plugins/sdk.ide: Fixed whitespace issues .../OSGI-INF/l10n/bundle.properties | 1 + plugins/org.yocto.sdk.ide/plugin.xml | 25 +- .../ide/natures/YoctoSDKCMakeProjectNature.java | 92 +++++++ .../src/org/yocto/sdk/ide/utils/YoctoSDKUtils.java | 7 +- .../sdk/ide/wizard/NewYoctoCProjectTemplate.java | 245 ------------------- .../ide/wizard/NewYoctoProjectTemplateProcess.java | 256 ++++++++++++++++++++ .../EmptyCAutotoolsProject/template.xml | 1 + .../EmptyCPPAutotoolsProject/template.xml | 1 + .../HelloWorldCAutotoolsProject/template.xml | 1 + .../HelloWorldCGTKAutotoolsProject/template.xml | 1 + .../HelloWorldCPPAutotoolsProject/template.xml | 1 + 11 files changed, 384 insertions(+), 247 deletions(-) create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/natures/YoctoSDKCMakeProjectNature.java delete mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoCProjectTemplate.java create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoProjectTemplateProcess.java -- 1.7.9.5 _______________________________________________ yocto mailing list yocto@yoctoproject.org<mailto:yocto@yoctoproject.org> https://lists.yoctoproject.org/listinfo/yocto
_______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
