Hi Jessica, I have rebased the patches and included the changes you suggested. Please review v2 of these patches.
Thanks, Ioana ________________________________________ From: Zhang, Jessica Sent: Wednesday, May 01, 2013 10:11 PM To: Grigoropol, IoanaX; yocto@yoctoproject.org Subject: RE: [yocto] [PATCH 0/8] Refactoring of remotetools plugin Hi Ioana, Overall looks good with few comment/question that I provide separately. Thanks, Jessica -----Original Message----- From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On Behalf Of Ioana Grigoropol Sent: Tuesday, April 30, 2013 7:36 AM To: yocto@yoctoproject.org Subject: [yocto] [PATCH 0/8] Refactoring of remotetools plugin - refactor all remote tools plugin to have single points of control for remote utilities plugin - remove all duplicate code Ioana Grigoropol (8): Remove UstLegacyModel since it is no longer supported Refactor Model(s) to display customized messages Unify preProcess for all commands models Add default behaviour for commands for post processing Remove duplicate code when getting remote data from powertop and ust2 Refactor RemoteApplication implementation Refactor powertop, oprofile and ust2 models to remote duplicate code Refactor Latencytop and Perf Handler to remove duplicate code .../yocto/sdk/remotetools/actions/BaseModel.java | 114 +++++++--- .../sdk/remotetools/actions/IBaseConstants.java | 3 + .../sdk/remotetools/actions/LatencytopHandler.java | 22 +- .../sdk/remotetools/actions/OprofileModel.java | 79 ++----- .../yocto/sdk/remotetools/actions/PerfHandler.java | 22 +- .../sdk/remotetools/actions/PowertopModel.java | 91 ++------ .../sdk/remotetools/actions/SystemtapModel.java | 34 ++- .../sdk/remotetools/actions/TerminalHandler.java | 16 +- .../yocto/sdk/remotetools/actions/Ust2Model.java | 132 +++-------- .../sdk/remotetools/actions/UstModelLegacy.java | 238 -------------------- .../sdk/remotetools/remote/RemoteApplication.java | 155 ------------- .../sdk/remotetools/remote/RemoteShellExec.java | 149 ++++++++++++ 12 files changed, 346 insertions(+), 709 deletions(-) delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/UstModelLegacy.java delete mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/remote/RemoteApplication.java create mode 100644 plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/remote/RemoteShellExec.java -- 1.7.9.5 _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
