Hi Ioana,
I merged 02-04 patches since they're clear to me what they meant for. As to
rest, I've provided some feedbacks. So please rebase against master. Also in
general, please send out patches to clearly mark what they're meant for and
please don't send a big patch set that contains everything, esp. multiple
versions without clearly marked how they're grouped.
Thanks,
Jessica
-----Original Message-----
From: Grigoropol, IoanaX
Sent: Thursday, May 09, 2013 1:19 AM
To: Zhang, Jessica; yocto@yoctoproject.org
Subject: RE: [yocto] [PATCH 3/3] Move filtering of suitable connections to
RSEHelper
Hi Jessica,
Please have a look at the last set of 12 patches I have sent. These should
apply cleanly on the master HEAD.
It contains both patch sets for refactoring(4 patches) and creating a new
separate plugin for remote tools(8 patches).
Thanks,
Ioana
________________________________________
From: yocto-boun...@yoctoproject.org [yocto-boun...@yoctoproject.org] on behalf
of Grigoropol, IoanaX [ioanax.grigoro...@intel.com]
Sent: Thursday, May 09, 2013 10:21 AM
To: Zhang, Jessica; yocto@yoctoproject.org
Subject: Re: [yocto] [PATCH 3/3] Move filtering of suitable connections to
RSEHelper
Hi Jessica,
Yes, you are right, sorry about that. I will send a v2 of this patch set.
Thanks,
Ioana
________________________________________
From: Zhang, Jessica
Sent: Thursday, May 09, 2013 12:54 AM
To: Grigoropol, IoanaX; yocto@yoctoproject.org
Subject: RE: [yocto] [PATCH 3/3] Move filtering of suitable connections to
RSEHelper
Hi Ioana,
Isn't the logic in RSEHelper is reversed? It should be:
if (sysType == null ||! sysType.isEnabled()) {
iter.remove();
}
Thanks,
Jessica
-----Original Message-----
From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On
Behalf Of Ioana Grigoropol
Sent: Wednesday, May 08, 2013 5:55 AM
To: yocto@yoctoproject.org
Subject: [yocto] [PATCH 3/3] Move filtering of suitable connections to RSEHelper
- BaseSettingDialog performs an extra filtering for suitable connections for a
given host by checking the remote system type
- this checking should be done in RSEHelper since it involves a remote
action and thus removing BaseSettingDialog dependency on RSE Api
- modified RSEHelper.getSuitableConnections to include the filtering
for connections with associated system type disabled
Signed-off-by: Ioana Grigoropol <ioanax.grigoro...@intel.com>
---
.../src/org/yocto/sdk/remotetools/RSEHelper.java | 4 ++++
.../sdk/remotetools/actions/BaseSettingDialog.java | 10 +++-------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git
a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/RSEHelper.java
b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/RSEHelper.java
index d1a505d..8d0612a 100644
---
a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/RSEHelper.java
+++ b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/RS
+++ EHelper.java
@@ -150,6 +150,10 @@ public class RSEHelper {
if(!terminalConnections.contains(fileConnection) &&
!shellConnections.contains(fileConnection)){
iter.remove();
}
+ IRSESystemType sysType = fileConnection.getSystemType();
+ if (sysType != null && sysType.isEnabled()) {
+ iter.remove();
+ }
}
return (IHost[]) filConnections.toArray(new
IHost[filConnections.size()]); diff --git
a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/BaseSettingDialog.java
b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/BaseSettingDialog.java
index 06eeb00..962a20a 100644
---
a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/BaseSettingDialog.java
+++ b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/ac
+++ tions/BaseSettingDialog.java
@@ -26,7 +26,6 @@ import org.yocto.sdk.remotetools.SWTFactory;
import org.yocto.sdk.remotetools.RSEHelper;
import org.eclipse.jface.dialogs.Dialog; import
org.eclipse.jface.dialogs.IDialogConstants;
-import org.eclipse.rse.core.IRSESystemType;
import org.eclipse.rse.core.model.IHost; import
org.eclipse.rse.ui.actions.SystemNewConnectionAction;
import org.eclipse.swt.SWT;
@@ -185,12 +184,9 @@ public class BaseSettingDialog extends Dialog {
connectionCombo.removeAll();
IHost[] connections = RSEHelper.getSuitableConnections();
for (int i = 0; i < connections.length; i++) {
- IRSESystemType sysType = connections[i].getSystemType();
- if (sysType != null && sysType.isEnabled()) {
-
connectionCombo.add(connections[i].getAliasName());
-
if(connections[i].getAliasName().equals(curConn))
- index=i;
- }
+ connectionCombo.add(connections[i].getAliasName());
+ if(connections[i].getAliasName().equals(curConn))
+ index=i;
}
if(index>=0) {
--
1.7.9.5
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
