Hi Ioana, I've provided detailed info regarding each patch. Please have them addressed and resubmit. I'll hold off review of the other RFC series till we have this set settled.
Thanks, Jessica -----Original Message----- From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On Behalf Of Ioana Grigoropol Sent: Tuesday, June 04, 2013 6:26 AM To: yocto@yoctoproject.org Subject: [yocto] [Refactor RFC 0/9] Merging of windows-build with master Ioana Grigoropol (9): Rename RSEHelper to RemoteHelper to match usages in org.yocto.bc.ui.plugin Add remote tools classes needed for bitbake remote capabilities Remove ICommandResponseHandler from plugin and use org.yocto.remote.utils implementation Remove unused Bitbake Actions Remove storing of init script location Remove unused method loadInit in Activator Remove unused getInitScript from ProjectInfoHelper Use URI for storing project locations Redirect bitbake environment parsing to file & parse plugins/org.yocto.bc.ui/META-INF/MANIFEST.MF | 7 +- plugins/org.yocto.bc.ui/plugin.xml | 55 --- .../src/org/yocto/bc/bitbake/BBRecipe.java | 26 +- .../src/org/yocto/bc/bitbake/BBSession.java | 83 ++-- .../yocto/bc/bitbake/ICommandResponseHandler.java | 15 - .../org/yocto/bc/bitbake/ProjectInfoHelper.java | 58 +-- .../src/org/yocto/bc/bitbake/ShellSession.java | 32 +- .../src/org/yocto/bc/ui/Activator.java | 83 ++-- .../ui/actions/AbstractBitbakeCommandAction.java | 199 -------- .../bc/ui/actions/BitbakeBuildRecipeAction.java | 24 - .../bc/ui/actions/BitbakeCleanRecipeAction.java | 26 - .../yocto/bc/ui/actions/BitbakeImportAction.java | 106 ----- .../bc/ui/actions/BitbakeRebuildRecipeAction.java | 29 -- .../bc/ui/actions/LaunchVariableWizardAction.java | 16 +- .../bc/ui/editors/bitbake/BBVariableTextHover.java | 16 +- .../bc/ui/editors/bitbake/BitBakeFileEditor.java | 16 +- .../bitbake/BitBakeSourceViewerConfiguration.java | 14 +- .../src/org/yocto/bc/ui/filesystem/OEFile.java | 13 +- .../org/yocto/bc/ui/filesystem/OEFileSystem.java | 24 +- .../org/yocto/bc/ui/filesystem/YoctoLocation.java | 34 ++ .../src/org/yocto/bc/ui/model/ProjectInfo.java | 75 ++- .../yocto/bc/ui/views/RecipeContentProvider.java | 2 +- .../importProject/ImportYoctoProjectWizard.java | 7 +- .../yocto/bc/ui/wizards/install/InstallWizard.java | 39 +- .../BBConfigurationInitializeOperation.java | 3 +- .../newproject/CreateBBCProjectOperation.java | 20 +- .../org.yocto.remote.utils/META-INF/MANIFEST.MF | 8 +- .../yocto/remote/utils/CommandOutputProcessor.java | 33 ++ .../yocto/remote/utils/CommandResponseHandler.java | 36 ++ .../org/yocto/remote/utils/CommandRunnable.java | 34 ++ .../src/org/yocto/remote/utils/ConsoleHelper.java | 28 ++ .../org/yocto/remote/utils/ConsoleRunnable.java | 37 ++ .../remote/utils/ICommandResponseHandler.java | 15 + .../org/yocto/remote/utils/OutputProcessor.java | 102 ++++ .../yocto/remote/utils/ProcessStreamBuffer.java | 77 +++ .../src/org/yocto/remote/utils/RSEHelper.java | 344 ------------- .../src/org/yocto/remote/utils/RemoteHelper.java | 503 ++++++++++++++++++++ .../src/org/yocto/remote/utils/RemoteMachine.java | 206 ++++++++ .../org/yocto/remote/utils/RemoteShellExec.java | 2 +- .../src/org/yocto/remote/utils/Session.java | 117 +++++ .../org/yocto/remote/utils/TerminalHandler.java | 2 +- .../src/org/yocto/remote/utils/YoctoCommand.java | 53 +++ .../yocto/sdk/remotetools/actions/BaseModel.java | 6 +- .../sdk/remotetools/actions/BaseSettingDialog.java | 12 +- 44 files changed, 1591 insertions(+), 1046 deletions(-) delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/bitbake/ICommandResponseHandler.java delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/actions/AbstractBitbakeCommandAction.java delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/actions/BitbakeBuildRecipeAction.java delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/actions/BitbakeCleanRecipeAction.java delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/actions/BitbakeImportAction.java delete mode 100644 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/actions/BitbakeRebuildRecipeAction.java create mode 100755 plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/filesystem/YoctoLocation.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/CommandOutputProcessor.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/CommandResponseHandler.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/CommandRunnable.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/ConsoleHelper.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/ConsoleRunnable.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/ICommandResponseHandler.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/OutputProcessor.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/ProcessStreamBuffer.java delete mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/RSEHelper.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/RemoteHelper.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/RemoteMachine.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/Session.java create mode 100644 plugins/org.yocto.remote.utils/src/org/yocto/remote/utils/YoctoCommand.java -- 1.7.9.5 _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
