On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kam...@intel.com wrote: > From: Nitin A Kamble <nitin.a.kam...@intel.com>
I've avoided too much feedback on the commit message, but these are nearly as important as the content itself. So I'll spend some time on just this one and leave it to you to extend to the others. > This enables kernel configuration for bunch of PCI media capture ^ a :-) and elsewhere > devices. Convention would be to speak in the imperative, so drop the "This" and replace "enables" with "Enable". "Enable kernel configuration for PCI media capture devices." Or perhaps more appropriately: "Create a feature fragment for PCI media capture devices." If you made any non-obvious decisions in preparing this fragment, please note them here as well. Did you drop any specific options? Did you included something that appears out of place to avoid extra complexity elsewhere, etc. > Signed-off-by: Nitin A Kamble <nitin.a.kam...@intel.com> > --- > .../kernel-cache/features/media/pci-capture.cfg | 80 > ++++++++++++++++++++++ > .../kernel-cache/features/media/pci-capture.scc | 8 +++ > 2 files changed, 88 insertions(+) > create mode 100644 meta/cfg/kernel-cache/features/media/pci-capture.cfg > create mode 100644 meta/cfg/kernel-cache/features/media/pci-capture.scc > > diff --git a/meta/cfg/kernel-cache/features/media/pci-capture.cfg > b/meta/cfg/kernel-cache/features/media/pci-capture.cfg > new file mode 100644 > index 0000000..232de32 > --- /dev/null > +++ b/meta/cfg/kernel-cache/features/media/pci-capture.cfg > @@ -0,0 +1,80 @@ > +# > +# Media capture support for PCI devices > +# > +CONFIG_MEDIA_PCI_SUPPORT=y > + > +# > +# Media capture/analog TV support > +# > +CONFIG_VIDEO_IVTV=m > +CONFIG_VIDEO_IVTV_ALSA=m > +CONFIG_VIDEO_FB_IVTV=m > + > +CONFIG_VIDEO_ZORAN=m > +CONFIG_VIDEO_ZORAN_DC30=m > +CONFIG_VIDEO_ZORAN_ZR36060=m > +# CONFIG_VIDEO_ZORAN_BUZ is not set Why? > +CONFIG_VIDEO_ZORAN_DC10=m > +CONFIG_VIDEO_ZORAN_LML33=m > +CONFIG_VIDEO_ZORAN_LML33R10=m > +CONFIG_VIDEO_ZORAN_AVS6EYES=m > + > +CONFIG_VIDEO_HEXIUM_GEMINI=m > +CONFIG_VIDEO_HEXIUM_ORION=m > +CONFIG_VIDEO_MXB=m > + > +# > +# Media capture/analog/hybrid TV support > +# > +CONFIG_VIDEO_CX18=m > +CONFIG_VIDEO_CX18_ALSA=m > + > +CONFIG_VIDEO_CX23885=m > +CONFIG_MEDIA_ALTERA_CI=m > + > +CONFIG_VIDEO_CX25821=m > +CONFIG_VIDEO_CX25821_ALSA=m > + > +CONFIG_VIDEO_CX88=m > +CONFIG_VIDEO_CX88_ALSA=m > +CONFIG_VIDEO_CX88_BLACKBIRD=m > +CONFIG_VIDEO_CX88_DVB=m > +CONFIG_VIDEO_CX88_VP3054=m > +CONFIG_VIDEO_CX88_MPEG=m > + > +CONFIG_VIDEO_BT848=m > +CONFIG_DVB_BT8XX=m > + > +CONFIG_VIDEO_SAA7134=m > +CONFIG_VIDEO_SAA7134_ALSA=m > +CONFIG_VIDEO_SAA7134_RC=y > +CONFIG_VIDEO_SAA7134_DVB=m > +CONFIG_VIDEO_SAA7164=m > + > +# > +# Media digital TV PCI Adapters > +# > +CONFIG_DVB_AV7110=m > +CONFIG_DVB_AV7110_OSD=y > +CONFIG_DVB_BUDGET_CORE=m > +CONFIG_DVB_BUDGET=m > +CONFIG_DVB_BUDGET_CI=m > +CONFIG_DVB_BUDGET_AV=m > +CONFIG_DVB_BUDGET_PATCH=m > + > +CONFIG_DVB_B2C2_FLEXCOP_PCI=m > +# CONFIG_DVB_B2C2_FLEXCOP_PCI_DEBUG is not set Defaults to off I presume? > + > +CONFIG_DVB_PLUTO2=m > + > +CONFIG_DVB_DM1105=m > + > +CONFIG_DVB_PT1=m > + > +CONFIG_MANTIS_CORE=m > +CONFIG_DVB_MANTIS=m > +CONFIG_DVB_HOPPER=m > + > +CONFIG_DVB_NGENE=m > + > +CONFIG_DVB_DDBRIDGE=m > diff --git a/meta/cfg/kernel-cache/features/media/pci-capture.scc > b/meta/cfg/kernel-cache/features/media/pci-capture.scc > new file mode 100644 > index 0000000..e24e6c8 > --- /dev/null > +++ b/meta/cfg/kernel-cache/features/media/pci-capture.scc > @@ -0,0 +1,8 @@ > +define KFEATURE_DESCRIPTION "Enable Configuration For Media PCI Capture > Devices" > +define KFEATURE_COMPATIBILITY all > + > +include media.scc > +include ../pci/pci.scc > +include common.scc order again, pci first. > + > +kconf hardware pci-capture.cfg -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ linux-yocto mailing list linux-yo...@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto