On Thu, Mar 20, 2014 at 7:29 AM, Burton, Ross <ross.bur...@intel.com> wrote:
> On 19 March 2014 20:51, Elizabeth Flanagan <elizabeth.flana...@intel.com>
> wrote:
>> + if "poky" in self.layername or \
>> + "oecore" in self.layername or \
>> + "eclipse" in self.layername:
>
> Do you actually need to do substring comparisons (in vs is) there? I
> suspect not, so I prefer this idiom as it involves less repetition:
>
> if self.layername in ('poky', 'oecore', 'eclipse')
In this case, yeah, we need a substring comparision, as we need to
support the layer being named eclipse-poky-<branch-name> and
poky/poky-contrib. We need to eventually figure out a better, more
standardized way of indicating the base layer, but until we do and
propagate that change out (as it changes configs), doing it this way
both supports the way people have come to understand what "base" is.
-b
>
> Ross
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
--
Elizabeth Flanagan
Yocto Project
Build and Release
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
