On Thursday 16 April 2015 07:35:40 Christopher Larson wrote: > On Thu, Apr 16, 2015 at 7:25 AM, Nicolas Dechesne < > > nicolas.deche...@linaro.org> wrote: > > On Thu, Apr 16, 2015 at 3:11 PM, Anders Darander <and...@chargestorm.se> > > > > wrote: > >> > > Running the recipe resulted in do_fetch (or do_unpack) failing again > >> > >> and > >> > >> > > complaining about missing files. This time the deletion was on a much > >> > > greater scale, it had deleted so much of my home-dir that my user > >> > > account was rendered entirely useless. The fastest way to recover > >> > > this > >> > > time was re-installing the machine. > >> > >> It's most likely a call to bb.utils.prunedir(destdir), with destdir > >> being set to '/'... > > > > ouch... this is a bit scary ;-) > > > > maybe we should assert the folder name is 'sane' when we do destructive > > operations like that. e.g. check that we are in TMPDIR, or TOPDIR.. > > > > hopefully nobody does sudo bitbake ;-) > > This is scary indeed. We definitely need to be more careful about calls to > dirname/basename with paths with a trailing or leading / in general, and > especially for removals, and just need to do more path > sanitization/normalization probably..
I have sent an additional patch to the bitbake list to try to protect against future instances of this issue, at least for bb.utils.prunedir() and bb.utils.remove(): http://lists.openembedded.org/pipermail/bitbake-devel/2015-April/005664.html Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto