On 31-03-16 23:27, Aníbal Limón wrote:
We have an issue when ls segfaults in some cases [1] so it's
better to detect the failure at this level instead of continue
the build process.

[YOCTO #8926]

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8926#c0

Signed-off-by: Aníbal Limón <anibal.li...@linux.intel.com>
---
  opkg-build | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/opkg-build b/opkg-build
index 98008b6..a9ccad2 100755
--- a/opkg-build
+++ b/opkg-build
@@ -53,6 +53,10 @@ pkg_appears_sane() {
                echo "*** Warning: The following files have names ending in '~'.
  You probably want to remove them: " >&2
                ls -ld $tilde_files
+               if [ $? -ne 0 ]; then

Instead of using $? you could just use the result of "ls" directly, i.e.:

if ! ls -ld $tilde_files; then


+                       echo "*** Error: Fail to list files have names ending in 
'~'."
+                       exit 1
+               fi
                echo >&2
            else
                echo "*** Removing the following files: $tilde_files"
@@ -66,6 +70,10 @@ You probably want to remove them: " >&2
                echo "*** Warning: The following files have a UID greater than 
99.
  You probably want to chown these to a system user: " >&2
                ls -ld $large_uid_files
+               if [ $? -ne 0 ]; then
+                       echo "*** Error: Fail to list files have a UID greater than 
99."
+                       exit 1
+               fi
                echo >&2
        fi
        




Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijm...@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail





--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to