> On Aug 26, 2016, at 4:25 PM, Khem Raj <raj.k...@gmail.com> wrote: > > > > On 8/26/16 3:45 PM, Jianxun Zhang wrote: >> The removed static linking was for a desire to make rmc run >> on systems where c libraries are not provided. >> >> But it is nothing wrong to dynamically link rmc with libraries. >> We also don't have to hardcode the way of linking in Makefile >> since people can specify it in RMC_CFLAGS passed to make command. >> > > have you tested the dynamic version ? Khem,
In RMC, two different test stages are defined in workflow. Please refer to "Patch submission & Maintenance” in README in rmc project. This patch to upstream rmc project was tested against rmc internal test suite (1st test stage) with yocto minimal images, RMC binaries built with the image, and another pending hash-style patch in recipe. See below. A QA checker of hash style in OE will fail once the --static is gone because it only expects gnu_hash for SYMTAB in dynamic section in ELF. The patch of hash issue in rmc recipe is under test (2nd test stage) with builtin examples in meta-intel for the next rmc revision update. This fix for an OE-specifc enforcement should be another step beyond this upstream patch’s submission and rmc project. But I probably should mention it in submission for a better clarity. Hope the info could help. Feel free to let me know anything I missed. Thanks! > >> Signed-off-by: Jianxun Zhang <jianxun.zh...@linux.intel.com> >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index e873af6..f152829 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -17,7 +17,7 @@ RMC_INSTALL_BIN_PATH := $(RMC_INSTALL_PREFIX)/bin/ >> >> ALL_OBJS := $(RMC_TOOL_OBJ) $(RMCL_OBJ) $(RSMP_OBJ) >> >> -CFLAGS := -static -Wall -O2 -Iinc $(RMC_CFLAGS) >> +CFLAGS := -Wall -O2 -Iinc $(RMC_CFLAGS) >> >> all: rmc librmcl librsmp >> >> -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
