On Fri, Feb 17, 2017 at 3:39 PM, Christopher Larson <kerg...@gmail.com>
wrote:
> On Fri, Feb 17, 2017 at 2:26 PM, Aníbal Limón <
> anibal.li...@linux.intel.com> wrote:
>
>> + parser.add_argument('-l', '--layer', metavar='LAYER_DIR',
>> + help='Layer to test compatibility with Yocto Project',
>> + action='store', required=True)
>>
>
> The behavior of this argument is quite unintuitive. First, this path isn’t
> actually used as the layer directory, detect_layers searches down from that
> path to *find* layers in that subdirectory, so the argument isn’t what it
> says it is. Second, why are you making an option mandatory rather than just
> using arguments?
>
> That is, why `layer-compat-layer.py -l layerpath` rather than
> `layer-compat-layer.py layerpath`. If you change the call to
> `parser.add_argument(‘layer’, …)` it’d change to the latter behavior.
>
Worth noting that you could, and probably should, also use nargs=‘+’ to let
the user specify multiple layers to check, rather than a single path, if
you go the latter route, and if not, you could change it to an append style
(for the ‘action’) argument to accomplish the same.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
