Great, thanks for the review!
On Sun, Feb 19, 2017 at 3:17 AM, Jacob Chen <jacobchen...@gmail.com> wrote: > Hi Trevor, > > 2017-02-19 13:03 GMT+08:00 Eddie Cai <eddie.cai.li...@gmail.com>: >> Hi Trevor >> >> 2017-02-19 10:43 GMT+08:00 Trevor Woerner <twoer...@gmail.com>: >>> Set the default preferred bootloader for firefly-rk3288 to be >>> u-boot-rockchip >>> and set the default name of the SPL binary. >>> >>> Signed-off-by: Trevor Woerner <twoer...@gmail.com> >>> --- >>> conf/machine/firefly-rk3288.conf | 1 + >>> conf/machine/include/rk3288.inc | 3 +++ >>> 2 files changed, 4 insertions(+) >> Reviewed-by Eddie Cai <eddie.cai.li...@gmail.com> >>> >>> diff --git a/conf/machine/firefly-rk3288.conf >>> b/conf/machine/firefly-rk3288.conf >>> index 8fa005d..58d752b 100644 >>> --- a/conf/machine/firefly-rk3288.conf >>> +++ b/conf/machine/firefly-rk3288.conf >>> @@ -8,3 +8,4 @@ >>> >>> include conf/machine/include/rk3288.inc >>> KERNEL_DEVICETREE = "rk3288-firefly.dtb" >>> +UBOOT_MACHINE = "firefly-rk3288_defconfig" >>> diff --git a/conf/machine/include/rk3288.inc >>> b/conf/machine/include/rk3288.inc >>> index 769e5c1..4a4201f 100644 >>> --- a/conf/machine/include/rk3288.inc >>> +++ b/conf/machine/include/rk3288.inc >>> @@ -10,3 +10,6 @@ PREFERRED_PROVIDER_virtual/kernel = "linux" >>> SERIAL_CONSOLES = "115200;ttyS2" >>> KERNEL_IMAGETYPE = "zImage" >>> KBUILD_DEFCONFIG = "multi_v7_defconfig" >>> + >>> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip" >>> +SPL_BINARY ?= "u-boot-spl-dtb.bin" >>> -- >>> 2.12.0.rc1.48.g076c053 >>> >>> -- >>> _______________________________________________ >>> yocto mailing list >>> yocto@yoctoproject.org >>> https://lists.yoctoproject.org/listinfo/yocto >> -- >> _______________________________________________ >> yocto mailing list >> yocto@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/yocto > > > It looks good, Reviewed-by: Jacob Chen <jacob-c...@iotwrt.com> -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto