Here is my v5 of this patch, based on feedback from earlier reviews.

Changes since v4:
        - in addition to generating a -gpt.img (and creating a simpler symlink
          to it) also create a -boot.img in the deploy directory and create a
          simpler symlink to it for each build

Changes since v3:
        - I sent the wrong file when emailing v3


Changes since v2:
        - change commit message and call the "old" layout "legacy parameter"
          format instead of "rk-boot" format
        - rename generate_rk3288_image() to generate_rk3288_loader1_image()
        - leave any older gpt image files (with datestamp) in the deploy
          directory but just move the symlink so it always points to the most
          recent

        - leave size variable as GPTIMG_SIZE
        - leave the boot image name as BOOT_IMG since trying to add ${MACHINE}
          and ${DATETIME} causes the build to fail with "the basehash value
          changed... metadata is not deterministic...". I think what was
          wanted was that older gpt image files be left around, and this new
          logic does that in a different way and maintains a symlink to the
          latest

Changes since v1:
        - break large commits into smaller ones
        - rename the class and improve the commit message

Trevor Woerner (1):
  classes: rockchip-gpt-img: add

 classes/rockchip-gpt-img.bbclass | 143 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644 classes/rockchip-gpt-img.bbclass

-- 
2.12.0.rc1.48.g076c053

-- 
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to