On Thu, 2017-07-06 at 08:09 -0700, Stephano Cetola wrote: > On 07/06, Joshua Lock wrote: > > This still leaves us a bit brittle. What if someone adds whitespace > > around the assignment operator? Could you create a follow-on patch > > for > > that? > > > > Thanks! > > Actually, since the awk command just searches for self.targetsvar now > instead of ``self.targetsvar="``, it will match even if there are > spaces between the equal.
Context is important. It's not the awk command, it's the str.replace() > + targets = targets.replace('%s="' % self.targetsvar, '') we're going replace 'SOMEVARIABLE="' with '', but what if we get 'SOMEVARIABLE = "' ? > I did just realize that if the variable is NOT multi-line, e.g. > REFKIT_CI_POSTBUILD_SELFTESTS, this search will fail because of the > "next" command. Ah, yes. That could cause some surprises. > I'll puzzle over this a bit. Thanks! Joshua -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto