On Thu, May 10, 2018 at 4:32 PM, Martin Jansa <martin.ja...@gmail.com> wrote: > On Thu, May 10, 2018 at 04:11:00PM -0700, Andre McCurdy wrote: >> On Thu, May 10, 2018 at 3:50 PM, Martin Jansa <martin.ja...@gmail.com> wrote: >> > On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >> >> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa <martin.ja...@gmail.com> >> >> wrote: >> >> > see >> >> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >> >> >> >> Removing -fno-omit-frame-pointer isn't the same as adding >> >> -fomit-frame-pointer. Frame pointers may get enabled depending on the >> >> optimisation level etc (ie not only by -fno-omit-frame-pointer). >> > >> > Should I send v2 adding -fomit-frame-pointer instead of removing >> > -fno-omit-frame-pointer? >> > >> > The v1 fixes the issue for me with default config + DEBUG_BUILD. >> >> The v1 patch isn't wrong, it's just incomplete (the problem could come >> back if someone changes optimisation level or switches gcc to clang, >> etc). >> >> My choice would be a v2 patch which adds -fomit-frame-pointer to >> CFLAGS unconditionally for all ARM builds when Thumb is enabled. That >> should fix the problem for all optimisation levels etc and avoids >> building the main strace binary differently depending on whether or >> not ptest is enabled. > > Only for thumb? makes me a bit sad that thumb override was dropped by > you in > 351443d71eb246a946b41f12b54d57b36fe1574e
No need for a thumb over-ride. You can copy and paste from the musl recipe: CFLAGS_append_arm = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto